Hi, On Tue, Jun 7, 2011 at 3:50 AM, Diego Biurrun <[email protected]> wrote: > On Mon, Jun 06, 2011 at 04:00:16PM -0400, Ronald S. Bultje wrote: >> >> On Mon, Jun 6, 2011 at 1:13 PM, Diego Biurrun <[email protected]> wrote: >> > On Mon, Jun 06, 2011 at 12:39:28PM -0400, Ronald S. Bultje wrote: >> >> On Mon, Jun 6, 2011 at 11:09 AM, Diego Biurrun <[email protected]> wrote: >> >> > #ifdef DEBUG_SEEK >> >> > - printf("movi_end=0x%"PRIx64"\n", avi->movi_end); >> >> > + av_log(s, AV_LOG_DEBUG, "movi_end=0x%"PRIx64"\n", avi->movi_end); >> >> > #endif >> >> >> >> Is there a particular reason that this code does not use av_dlog()? >> > >> > Yes, av_dlog reacts to a #definition of DEBUG, while this code reacts >> > to DEBUG_SEEK being #defined or not. >> >> Patch OK. >> >> But now comes the obvious question: why not just s/DEBUG_SEEK/DEBUG/? >> You did that for other defines. > > I could do it. DEBUG_SEEK is more common than the other DEBUG defines, > I thought for a moment it might be worth keeping.
I'll leave that up to you, so feel free to keep it for now. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
