On 06/07/2011 07:03 PM, Diego Biurrun wrote:
> ---
> libavcodec/dvbsubdec.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
> index 66659ae..3f39a96 100644
> --- a/libavcodec/dvbsubdec.c
> +++ b/libavcodec/dvbsubdec.c
> @@ -35,6 +35,7 @@
>
> #ifdef DEBUG
> #undef fprintf
> +#undef perror
> #if 0
> static void png_save(const char *filename, uint8_t *bitmap, int w, int h,
> uint32_t *rgba_palette)
> @@ -49,7 +50,7 @@ static void png_save(const char *filename, uint8_t *bitmap,
> int w, int h,
> f = fopen(fname, "w");
> if (!f) {
> perror(fname);
> - exit(1);
> + return;
> }
> fprintf(f, "P6\n"
> "%d %d\n"
> @@ -71,7 +72,7 @@ static void png_save(const char *filename, uint8_t *bitmap,
> int w, int h,
> f = fopen(fname2, "w");
> if (!f) {
> perror(fname2);
> - exit(1);
> + return;
> }
> fprintf(f, "P5\n"
> "%d %d\n"
> @@ -105,7 +106,7 @@ static void png_save2(const char *filename, uint32_t
> *bitmap, int w, int h)
> f = fopen(fname, "w");
> if (!f) {
> perror(fname);
> - exit(1);
> + return;
> }
> fprintf(f, "P6\n"
> "%d %d\n"
> @@ -127,7 +128,7 @@ static void png_save2(const char *filename, uint32_t
> *bitmap, int w, int h)
> f = fopen(fname2, "w");
> if (!f) {
> perror(fname2);
> - exit(1);
> + return;
> }
> fprintf(f, "P5\n"
> "%d %d\n"
ok to the change.
But also, this should not be under #ifdef DEBUG. Saving images is way
too invasive for general debugging code. The original DEBUG_SAVE_IMAGES
or whatever it was seems like a better option.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
