On 06/09/2011 06:27 AM, Anton Khirnov wrote:

> It stores options in a dictionary to be passed to new open calls.
> 
> It will replace opt_default once all the pieces are in place.
> ---
> +#define FLAGS (o->type == FF_OPT_TYPE_FLAGS) ? AV_DICT_APPEND : 0
> +#define SET_PREFIXED_OPTS(ch, flag, output) \
> +    if (opt[0] == ch && avcodec_opts[0] && (o = av_opt_find(avcodec_opts[0], 
> opt+1, NULL, flag, 0)))\
> +        av_dict_set(&output, opt+1, arg, FLAGS);
[...]
> +#undef FLAGS
> +#undef SET_PREFIXED_OPTS


are the #undef really necessary?

rest of the patch looks ok.

-Justin

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to