On Thu, 09 Jun 2011 10:47:15 -0400, Justin Ruggles <[email protected]> wrote: > On 06/09/2011 09:53 AM, Ronald S. Bultje wrote: > > > Hi, > > > > On Thu, Jun 9, 2011 at 9:17 AM, Justin Ruggles <[email protected]> > > wrote: > >> On 06/09/2011 06:27 AM, Anton Khirnov wrote: > >> > >>> +const AVOption *av_opt_find(void *obj, const char *name, const char > >>> *unit, > >>> + int opt_flags, int search_flags) > >>> +{ > >>> + AVClass *c = *(AVClass**)obj; > >>> + const AVOption *o = NULL; > >>> + > >>> + if (c->opt_find && search_flags & AVOPT_SEARCH_CHILDREN && > >>> + (o = c->opt_find(obj, name, unit, opt_flags, search_flags))) > >>> + return o; > >>> + > >>> + while ((o = av_next_option(obj, o))) { > >> > >> > >> extra unneeded parentheses. > > > > No, these are needed: =, not ==. > > > I meant just for the while(). Are the double set of parens really > required there? >
Hmm, i thought gcc warned about if (foo = bar()) but seems not. Removed locally. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
