On Sun, Jun 26, 2011 at 05:21:19AM -0700, Jason Garrett-Glaser wrote:
> On Sun, Jun 26, 2011 at 5:12 AM, Diego Biurrun <[email protected]> wrote:
> > On Sun, Jun 26, 2011 at 05:03:56AM -0700, Jason Garrett-Glaser wrote:
> >> On Sun, Jun 26, 2011 at 4:58 AM, Diego Biurrun <[email protected]> wrote:
> >> > On Sat, Jun 25, 2011 at 07:54:30PM -0700, Jason Garrett-Glaser wrote:
> >> >>
> >> >> --- a/libavcodec/h264_loopfilter.c
> >> >> +++ b/libavcodec/h264_loopfilter.c
> >> >> @@ -264,16 +265,46 @@ void ff_h264_filter_mb_fast( H264Context *h, int
> >> >> mb_x, int mb_y, uint8_t *img_y,
> >> >> filter_mb_edgeh( &img_y[4*3*linesize], linesize, bS3, qp,
> >> >> h);
> >> >> }
> >> >> if(chroma){
> >> >> - if(left_type){
> >> >> - filter_mb_edgecv( &img_cb[2*0], uvlinesize, bS4, qpc0,
> >> >> h);
> >> >> - filter_mb_edgecv( &img_cr[2*0], uvlinesize, bS4, qpc0,
> >> >> h);
> >> >> + if(chroma444){
> >> >> + if(left_type){
> >> >> + filter_mb_edgev( &img_cb[4*0], linesize, bS4,
> >> >> qpc0, h);
> >> >> + filter_mb_edgev( &img_cr[4*0], linesize, bS4,
> >> >> qpc0, h);
> >> >> + }
> >> >> + if( IS_8x8DCT(mb_type) ) {
> >> >
> >> > nit: consistent spacing please
> >>
> >> I'm only copying the existing spacing; changing that should probably
> >> be a separate patch.
> >
> > not quite:
> >
> > if(chroma){
> > if(left_type){
> >
> > --->
> >
> > if(chroma){
> > if(left_type){
> > if( IS_8x8DCT(mb_type) ) {
> >
> > Notice the spaces inside the parentheses.
>
> Yes, those are in the original code.
What I mean is that
if( IS_8x8DCT(mb_type) ) {
is a line you added; it was not there before.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
