On Sun, Jun 26, 2011 at 2:27 PM, Diego Biurrun <[email protected]> wrote: > On Sun, Jun 26, 2011 at 08:01:45AM -0700, Jason Garrett-Glaser wrote: >> On Sun, Jun 26, 2011 at 6:00 AM, Diego Biurrun <[email protected]> wrote: >> > On Sun, Jun 26, 2011 at 05:21:19AM -0700, Jason Garrett-Glaser wrote: >> >> On Sun, Jun 26, 2011 at 5:12 AM, Diego Biurrun <[email protected]> wrote: >> >> > On Sun, Jun 26, 2011 at 05:03:56AM -0700, Jason Garrett-Glaser wrote: >> >> >> On Sun, Jun 26, 2011 at 4:58 AM, Diego Biurrun <[email protected]> >> >> >> wrote: >> >> >> > On Sat, Jun 25, 2011 at 07:54:30PM -0700, Jason Garrett-Glaser wrote: >> >> >> >> >> >> >> >> --- a/libavcodec/h264_loopfilter.c >> >> >> >> +++ b/libavcodec/h264_loopfilter.c >> >> >> >> @@ -264,16 +265,46 @@ void ff_h264_filter_mb_fast( H264Context *h, >> >> >> >> int mb_x, int mb_y, uint8_t *img_y, >> >> >> >> filter_mb_edgeh( &img_y[4*3*linesize], linesize, bS3, >> >> >> >> qp, h); >> >> >> >> } >> >> >> >> if(chroma){ >> >> >> >> - if(left_type){ >> >> >> >> - filter_mb_edgecv( &img_cb[2*0], uvlinesize, bS4, >> >> >> >> qpc0, h); >> >> >> >> - filter_mb_edgecv( &img_cr[2*0], uvlinesize, bS4, >> >> >> >> qpc0, h); >> >> >> >> + if(chroma444){ >> >> >> >> + if(left_type){ >> >> >> >> + filter_mb_edgev( &img_cb[4*0], linesize, bS4, >> >> >> >> qpc0, h); >> >> >> >> + filter_mb_edgev( &img_cr[4*0], linesize, bS4, >> >> >> >> qpc0, h); >> >> >> >> + } >> >> >> >> + if( IS_8x8DCT(mb_type) ) { >> >> >> > >> >> >> > nit: consistent spacing please >> >> >> >> >> >> I'm only copying the existing spacing; changing that should probably >> >> >> be a separate patch. >> >> > >> >> > not quite: >> >> > >> >> > if(chroma){ >> >> > if(left_type){ >> >> > >> >> > ---> >> >> > >> >> > if(chroma){ >> >> > if(left_type){ >> >> > if( IS_8x8DCT(mb_type) ) { >> >> > >> >> > Notice the spaces inside the parentheses. >> >> >> >> Yes, those are in the original code. >> > >> > What I mean is that >> > >> > if( IS_8x8DCT(mb_type) ) { >> > >> > is a line you added; it was not there before. >> >> Yes it was there before. Please look again. > > Been there, done that - the line is added in your patch and was not > there before. Witness that it is prefixed by '+', which indicates > added lines in unified diffs and there is no matching line prefixed > with '-' that would indicate a line that was there before.
It is not a new line, it is a copy of an existing line. If I make a copy of a movie, it's not a new movie; it's still the same movie. Jason _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
