On Sun, Jul 03, 2011 at 12:39:16PM +0100, Måns Rullgård wrote:
> Diego Biurrun <[email protected]> writes:
>
> > --- a/libavcodec/dwt.c
> > +++ b/libavcodec/dwt.c
> > @@ -130,6 +130,7 @@ lift(DWTELEM *dst, DWTELEM *src, DWTELEM *ref,
> >
> > +#if 0
> > static av_always_inline void
> > inv_lift(IDWTELEM *dst, IDWTELEM *src, IDWTELEM *ref,
> > int dst_step, int src_step, int ref_step,
> > @@ -196,6 +198,7 @@ liftS(DWTELEM *dst, DWTELEM *src, DWTELEM *ref,
> > }
> > +#if 0
> > static av_always_inline void
> > inv_liftS(IDWTELEM *dst, IDWTELEM *src, IDWTELEM *ref,
> > int dst_step, int src_step, int ref_step,
>
> Adding #if 0? WTF??
The functions are referenced under '#if 0'. Should I remove the calls
as well?
> > --- a/libavformat/asfdec.c
> > +++ b/libavformat/asfdec.c
> > @@ -83,14 +83,14 @@ typedef struct {
> > static const ff_asf_guid index_guid = {
> > 0x90, 0x08, 0x00, 0x33, 0xb1, 0xe5, 0xcf, 0x11, 0x89, 0xf4, 0x00,
> > 0xa0, 0xc9, 0x03, 0x49, 0xcb
> > };
> > +/**********************************/
> > +/* decoding */
> >
> > +#ifdef DEBUG
> > static const ff_asf_guid stream_bitrate_guid = { /* (http://get.to/sdp) */
> > 0xce, 0x75, 0xf8, 0x7b, 0x8d, 0x46, 0xd1, 0x11, 0x8d, 0x82, 0x00,
> > 0x60, 0x97, 0xc9, 0xa2, 0xb2
> > };
> > -/**********************************/
> > -/* decoding */
> >
> > -#ifdef DEBUG
> > #define PRINT_IF_GUID(g,cmp) \
> > if (!ff_guidcmp(g, &cmp)) \
> > av_dlog(NULL, "(GUID: %s) ", #cmp)
>
> This doesn't match the description.
Do you prefer updating the description or splitting the patch?
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
