Diego Biurrun <[email protected]> writes: > On Sun, Jul 03, 2011 at 01:40:49PM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > On Sun, Jul 03, 2011 at 12:39:16PM +0100, Måns Rullgård wrote: >> >> Diego Biurrun <[email protected]> writes: >> >> >> >> > --- a/libavcodec/dwt.c >> >> > +++ b/libavcodec/dwt.c >> >> > @@ -130,6 +130,7 @@ lift(DWTELEM *dst, DWTELEM *src, DWTELEM *ref, >> >> > >> >> > +#if 0 >> >> > static av_always_inline void >> >> > inv_lift(IDWTELEM *dst, IDWTELEM *src, IDWTELEM *ref, >> >> > int dst_step, int src_step, int ref_step, >> >> > @@ -196,6 +198,7 @@ liftS(DWTELEM *dst, DWTELEM *src, DWTELEM *ref, >> >> > } >> >> > +#if 0 >> >> > static av_always_inline void >> >> > inv_liftS(IDWTELEM *dst, IDWTELEM *src, IDWTELEM *ref, >> >> > int dst_step, int src_step, int ref_step, >> >> >> >> Adding #if 0? WTF?? >> > >> > The functions are referenced under '#if 0'. Should I remove the calls >> > as well? >> >> Didn't you have a patch removing a bunch of #if 0 code? > > I have a whole branch that does this. I submitted it once, but the > patches are large and went mostly unreviewed.
Splitting it up a bit (e.g. by codec) would have helped reviewing. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
