On 08/09/2011 04:54 AM, Anton Khirnov wrote:
> The new option doesn't depend on its placement wrt -new* options (which
> don't exist anymore) and works in a similar way as per-stream AVOptions.
>
> Breaks presets for now. But only libx264 uses them anyway and it now
> has the 'preset' private option, so presets in avconv serve no purpose.
[...]
> - { "apre", HAS_ARG | OPT_AUDIO | OPT_EXPERT, {(void*)opt_preset}, "set
> the audio options to the indicated preset", "preset" },
> - { "vpre", HAS_ARG | OPT_VIDEO | OPT_EXPERT, {(void*)opt_preset}, "set
> the video options to the indicated preset", "preset" },
> - { "spre", HAS_ARG | OPT_SUBTITLE | OPT_EXPERT, {(void*)opt_preset}, "set
> the subtitle options to the indicated preset", "preset" },
> - { "fpre", HAS_ARG | OPT_EXPERT, {(void*)opt_preset}, "set options from
> indicated preset file", "filename" },
> - /* data codec support */
> - { "dcodec", HAS_ARG | OPT_DATA, {(void*)opt_data_codec}, "force data
> codec ('copy' to copy stream)", "codec" },
> +// { "apre", HAS_ARG | OPT_AUDIO | OPT_EXPERT, {(void*)opt_preset}, "set
> the audio options to the indicated preset", "preset" },
> +// { "vpre", HAS_ARG | OPT_VIDEO | OPT_EXPERT, {(void*)opt_preset}, "set
> the video options to the indicated preset", "preset" },
> +// { "spre", HAS_ARG | OPT_SUBTITLE | OPT_EXPERT, {(void*)opt_preset},
> "set the subtitle options to the indicated preset", "preset" },
> +// { "fpre", HAS_ARG | OPT_EXPERT, {(void*)opt_preset}, "set options from
> indicated preset file", "filename" },
If they serve no purpose, why not remove them completely? Do you intend
to change this to -pre:a, -pre:v, etc...?
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
