"Ronald S. Bultje" <[email protected]> writes:

> Hi,
>
> On Tue, Aug 9, 2011 at 1:54 AM, Anton Khirnov <[email protected]> wrote:
>> ---
>>  tests/Makefile            |    6 +-
>>  tests/codec-regression.sh |  120 
>> ++++++++++++++++++++++----------------------
>>  tests/fate-run.sh         |   14 +++---
>>  tests/fate.mak            |   36 +++++++-------
>>  tests/fate/mp3.mak        |   14 +++---
>>  tests/fate2.mak           |    2 +-
>>  tests/lavf-regression.sh  |   50 +++++++++---------
>>  tests/lavfi-regression.sh |    8 ++--
>>  tests/regression-funcs.sh |   32 ++++++------
>>  9 files changed, 141 insertions(+), 141 deletions(-)
>
> I believe this patch would be a lot more logical and readable if:
> A) the switch from ffmpeg to avconv was done directly after the rename
> B) each subsequent (incompatible-to-ffmpeg) change was done together
> with the change in the regression test scripts

+1

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to