Hi,
On Tue, Aug 9, 2011 at 4:06 AM, Justin Ruggles <[email protected]> wrote:
> On 08/08/2011 07:45 PM, Ronald S. Bultje wrote:
>> On Sun, Aug 7, 2011 at 4:29 PM, Justin Ruggles <[email protected]>
>> wrote:
>>> Also use 'auto' as default.
>>> ---
>>> libavcodec/ac3enc_opts_template.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> OK.
>>
>> Bonus points for using macros/enums for this instead of hardcoded
>> integer numbers that we'll all forget about 6 months from now.
>
> Wouldn't doing that for private options pollute the public API with
> private codec option enums? I thought that's what the named option
> values were for... So you can do "-channel_coupling auto" instead of
> "-channel_coupling -1".
They wouldn't be exposed publicly. The AVOption indeed takes care of that.
All the enum/macro would do is unify the use of "magic integer
constants" in libavcodec/{e,}ac3enc*.[ch]. I consider that slightly
more readable to people relatively new to the code who want to have a
look to see how it works.
Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
