On Tue, Sep 06, 2011 at 02:17:48AM -0400, Dustin Brody wrote:
> ---
> libavcodec/mpeg12.c | 176 +++++++++++++++++++++++++-------------------------
> 1 files changed, 88 insertions(+), 88 deletions(-)
LGTM, but ...
> --- a/libavcodec/mpeg12.c
> +++ b/libavcodec/mpeg12.c
> @@ -91,16 +91,16 @@ static void init_2d_vlc_rl(RLTable *rl)
>
> if(len==0){ // illegal code
> run= 65;
> - level= MAX_LEVEL;
> + level = MAX_LEVEL;
> }else if(len<0){ //more bits needed
> run= 0;
> - level= code;
> + level = code;
> }else{
> if(code==rl->n){ //esc
> run= 65;
... I do wonder why you change some lines and not others, cf. the
three "run=" assignments above, more below.
> @@ -110,12 +110,12 @@ static void init_2d_vlc_rl(RLTable *rl)
> - rl->rl_vlc[0][i].len= len;
> - rl->rl_vlc[0][i].level= level;
> - rl->rl_vlc[0][i].run= run;
> + rl->rl_vlc[0][i].len = len;
> + rl->rl_vlc[0][i].level = level;
> + rl->rl_vlc[0][i].run = run;
And in places like this one you could align the '=' while you're at it.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
