On Tue, Sep 06, 2011 at 09:49:16AM -0700, Ronald S. Bultje wrote: > On Tue, Sep 6, 2011 at 2:51 AM, Diego Biurrun <[email protected]> wrote: > > --- > > libavcodec/mpeg12.c | 1519 > > +++++++++++++++++++++++++-------------------------- > > 1 files changed, 751 insertions(+), 768 deletions(-) > > > > diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c > > index 574f69a..2533794 100644 > > --- a/libavcodec/mpeg12.c > > +++ b/libavcodec/mpeg12.c > > @@ -1,6 +1,6 @@ > > /* > > * MPEG-1/2 decoder > > - * Copyright (c) 2000,2001 Fabrice Bellard > > + * Copyright (c) 2000, 2001 Fabrice Bellard > > * Copyright (c) 2002-2004 Michael Niedermayer <[email protected]> > > * > > * This file is part of Libav. > > @@ -49,28 +49,20 @@ > > #define MB_PTYPE_VLC_BITS 6 > > #define MB_BTYPE_VLC_BITS 6 > > > > -static inline int mpeg1_decode_block_intra(MpegEncContext *s, > > - DCTELEM *block, > > - int n); > > -static inline int mpeg1_decode_block_inter(MpegEncContext *s, > > - DCTELEM *block, > > - int n); > > +static inline int mpeg1_decode_block_intra(MpegEncContext *s, DCTELEM > > *block, int n); > > +static inline int mpeg1_decode_block_inter(MpegEncContext *s, DCTELEM > > *block, int n); > > This doesn't fit on 80 char terminals anymore.
Yes, but we have no clear policy about this. > Can we please not commit these kind of things super-fast? I'm all for > better indenting, but this sort of stuff is pretty fundamental and if > we have to reindent it 3x, it becomes a major pain. Let's find the > right uncrustify settings that work 100% right, not make it a little > better here and worse elsewhere. Point taken, but the issue I saw here was that already a patch which did partially reformat the file was submitted. I did not want to see the effort of the patch sender go to waste, but also avoid another round of reformatting later on. So I did this 90-95% solution, that is much better than before. Given the bikeshed potential of these changes, it may even be advisable not to discuss too long in order not to get bogged down in details. Yes, this can be improved slightly still and yes, maybe it even will, but hey, these are minor details and we got something done already. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
