Hi, On Fri, Oct 14, 2011 at 4:04 AM, Janne Grunau <[email protected]> wrote: > From: Steven Walters <[email protected]> > > On Thu, Oct 13, 2011 at 11:45:34PM +0200, Diego Biurrun wrote: >> On Thu, Oct 13, 2011 at 11:27:00PM +0200, Janne Grunau wrote: >> > >> > --- /dev/null >> > +++ b/libavcodec/w32pthreads.h >> > @@ -0,0 +1,208 @@ >> > + >> > +#ifndef AVCODEC_W32PTHREAD_H >> > +#define AVCODEC_W32PTHREAD_H >> >> This is not quite the filename (missing 's'). >> >> > +static int pthread_create(pthread_t *thread, const void *unused_attr, >> > + void *(*start_routine)(void*), void *arg) >> >> Indentation is off. >> >> > +/* for pre-Windows 6.0 platforms we need to define and use our own >> > condition >> > + * variable and api */ >> > +typedef struct >> > +{ >> >> typedef struct { >> >> > +#endif /* AVCODEC_W32PTHREAD_H */ >> >> see above > > all fixed > > Janne > ---8<--- > Replace our incomplete w32threads implementation with x264's pthreads > w32threads wrapper. > Relicensed to LGPL with kind permission by Pegasys Inc. > > Signed-off-by: Janne Grunau <[email protected]> > --- > libavcodec/Makefile | 2 +- > libavcodec/h264.c | 2 +- > libavcodec/h264_direct.c | 2 +- > libavcodec/mpeg12.c | 2 +- > libavcodec/mpegvideo.c | 2 +- > libavcodec/pthread.c | 13 +++- > libavcodec/utils.c | 6 +- > libavcodec/vp3.c | 8 +- > libavcodec/w32pthreads.h | 207 > ++++++++++++++++++++++++++++++++++++++++++++++ > libavcodec/w32thread.c | 176 --------------------------------------- > 10 files changed, 230 insertions(+), 190 deletions(-) > create mode 100644 libavcodec/w32pthreads.h > delete mode 100644 libavcodec/w32thread.c
Still LGTM. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
