On Wed,  7 Dec 2011 16:47:25 +0100, Luca Barbato <[email protected]> wrote:
> It behaves similarly to image2 muxer
> ---
>  doc/muxers.texi          |   32 ++++++
>  libavformat/Makefile     |    1 +
>  libavformat/allformats.c |    1 +
>  libavformat/segment.c    |  256 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 290 insertions(+), 0 deletions(-)
>  create mode 100644 libavformat/segment.c
> 

* avio_open -> avio_open2 please

* You seem to (ab)use lavf internals, like calling the function
pointers in AVOutputFormat directly, messing with private data etc. I
suppose that can't be avoided easily, but you should at least document
the reasons why it is needed and standard functions can't be used.

* It should warn or fail on multiple non-intra video streams.

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to