On 07/12/11 18:30, Anton Khirnov wrote:

* avio_open ->  avio_open2 please

Ok.

* You seem to (ab)use lavf internals, like calling the function
pointers in AVOutputFormat directly, messing with private data etc. I
suppose that can't be avoided easily, but you should at least document
the reasons why it is needed and standard functions can't be used.

It is as bad as it looks, but our current api doesn't work for this purpose. That means we should figure out how to make it lean enough.

* It should warn or fail on multiple non-intra video streams.

I was thinking about it.

btw, could you please run it through valgrind and help me track why

==25875== at 0x4C27168: memalign (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==25875== by 0x4C27217: posix_memalign (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==25875==    by 0x9E9189: av_strdup (mem.c:83)
==25875==    by 0x9EBC4E: av_opt_set_dict (opt.c:156)
==25875==    by 0x4F5D29: avformat_write_header (utils.c:2954)
==25875==    by 0x4398D3: transcode_init (avconv.c:2330)
==25875==    by 0x43C22A: main (avconv.c:2408)
==25875==
==25875== LEAK SUMMARY:
==25875==    definitely lost: 9 bytes in 1 blocks
==25875==    indirectly lost: 0 bytes in 0 blocks
==25875==      possibly lost: 0 bytes in 0 blocks
==25875==    still reachable: 0 bytes in 0 blocks
==25875==         suppressed: 0 bytes in 0 blocks

happens?

lu


--

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to