On Wed, Dec 14, 2011 at 09:09:58PM +0000, Måns Rullgård wrote:
> Diego Biurrun <[email protected]> writes:
> > --- /dev/null
> > +++ b/tests/fate/demux.mak
> > @@ -0,0 +1,41 @@
> > +FATE_TESTS += fate-adts-demux
> > +fate-adts-demux: CMD = crc  -i $(SAMPLES)/aac/ct_faac-adts.aac -acodec copy
> 
> I still think it makes sense to keep that one with the AAC tests.  It
> *is* AAC after all, even if it's not decoded.

I don't mind.  Alex?

> > +FATE_TESTS += fate-d-cinema-demux
> > +fate-d-cinema-demux: CMD = framecrc  -i 
> > $(SAMPLES)/d-cinema/THX_Science_FLT_1920-partial.302 -acodec copy -pix_fmt 
> > rgb24
> 
> Copy and -pix_fmt in the same command?  Something is not right here.

Possibly.  I'll consider that out of the scope of this patchset for now,
but everybody else is welcome to investigate.

> > +FATE_TESTS += fate-mpc7-demux
> > +fate-mpc7-demux: CMD = crc  -i $(SAMPLES)/musepack/inside-mp7.mpc -acodec 
> > copy
> > +
> > +FATE_TESTS += fate-mpc8-demux
> > +fate-mpc8-demux: CMD = crc  -i $(SAMPLES)/musepack/inside-mp8.mpc -acodec 
> > copy
> 
> Don't we have other Moosepack tests?

We have one other moose test, but just 3 feels like too few to warrant
splitting ...

> > +FATE_TESTS += fate-mxf-demux
> > +fate-mxf-demux: CMD = framecrc  -i $(SAMPLES)/mxf/C0023S01.mxf -acodec 
> > copy -vcodec copy
> 
> What does this test that fate-lavf-mxf does not?

Another good question that others are welcome to investigate...

> > +FATE_TESTS += fate-vqf-demux
> > +fate-vqf-demux: CMD = md5  -i $(SAMPLES)/vqf/achterba.vqf -acodec copy -f 
> > framecrc
> 
> This should go wherever the twinvq decoder tests are.

There is one twinvq test, which again feels like too few to split ..

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to