On Wed, Dec 14, 2011 at 09:41:39PM +0000, Måns Rullgård wrote:
> Diego Biurrun <[email protected]> writes:
> >> > +FATE_TESTS += fate-mpc7-demux
> >> > +fate-mpc7-demux: CMD = crc  -i $(SAMPLES)/musepack/inside-mp7.mpc 
> >> > -acodec copy
> >> > +
> >> > +FATE_TESTS += fate-mpc8-demux
> >> > +fate-mpc8-demux: CMD = crc  -i $(SAMPLES)/musepack/inside-mp8.mpc 
> >> > -acodec copy
> >> 
> >> Don't we have other Moosepack tests?
> >
> > We have one other moose test, but just 3 feels like too few to warrant
> > splitting ...
> 
> Then we need more, at a minimum we should have one test for each support
> codec variant.
> 
> >> > +FATE_TESTS += fate-vqf-demux
> >> > +fate-vqf-demux: CMD = md5  -i $(SAMPLES)/vqf/achterba.vqf -acodec copy 
> >> > -f framecrc
> >> 
> >> This should go wherever the twinvq decoder tests are.
> >
> > There is one twinvq test, which again feels like too few to split ..
> 
> They can still be in the same place, wherever that may be.

... more splitting then, don't you complain about more review work
to me then! ;)

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to