On Sat, Dec 24, 2011 at 02:00:15AM +0530, Aneesh Dogra wrote:
>
> --- a/libavcodec/mpegvideo_enc.c
> +++ b/libavcodec/mpegvideo_enc.c
> @@ -76,23 +78,23 @@ void ff_convert_matrix(DSPContext *dsp, int (*qmat)[64],
> uint16_t (*qmat16)[2][6
> } else if (dsp->fdct == fdct_ifast
> #ifndef FAAN_POSTSCALE
> - || dsp->fdct == ff_faandct
> + || dsp->fdct == ff_faandct
> #endif
> - ) {
> + ) {
This was correct before.
> @@ -113,64 +115,71 @@ void ff_convert_matrix(DSPContext *dsp, int
> (*qmat)[64], uint16_t (*qmat16)[2][6
>
> - for(i=intra; i<64; i++){
> - int64_t max= 8191;
> + for (i = intra; i < 64; i++) {
> + int64_t max = 8191;
> if (dsp->fdct == fdct_ifast
> #ifndef FAAN_POSTSCALE
> || dsp->fdct == ff_faandct
> #endif
> ) {
I repeat:
This is admittedly slightly tricky because of the #ifdef, but there
are 4 spaces too much indentation in the second and third line.
I must say this feels like I'm wasting my time. You have sent two new
patches since my review, but none of the two address (all) my review
comments. As a rule, you have to address review comments in order to
get a patch accepted, so sending intermediate versions just creates
unnecessary traffic.
If you have trouble understanding or implementing review comments, ask.
But sending patch after patch after patch just binds resources. Please
send less patches, but make sure you have thoroughly checked the ones
you send in. Thank you.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
