Hi,

On Mon, Dec 26, 2011 at 9:06 AM, Ronald S. Bultje <[email protected]> wrote:
> On Mon, Dec 26, 2011 at 7:31 AM, Aneesh Dogra <[email protected]> wrote:
>-        if (dsp->fdct == ff_jpeg_fdct_islow_8 ||
>-            dsp->fdct == ff_jpeg_fdct_islow_10
>+        if (dsp->fdct == ff_jpeg_fdct_islow_8  ||
>+            dsp->fdct == ff_jpeg_fdct_islow_10 ||
> #ifdef FAAN_POSTSCALE
>-            || dsp->fdct == ff_faandct
>+            dsp->fdct == ff_faandct
> #endif
>             ) {

This won't compile if FAAN_POSTSCALE is disabled, it will result in this code:

if (a || b ||) {
    ..
}

Which is an obvious syntax error. Again, I never pointed out that this
should be changed, in fact when you asked on IRC I very specifically
said that this particular case should _not_ be changed.

Please revert all such cases also.

Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to