On Sat, Dec 24, 2011 at 10:54:47PM +0530, Aneesh Dogra wrote:
> Is this what you meant by :-
>
> > This is admittedly slightly tricky because of the #ifdef, but there
> > are 4 spaces too much indentation in the second and third line.
>
> Secondly, I wanted to deliver that i am trying my level best to get
> what you suggest and implement them,
I don't doubt that. Let me clarify: I don't mind you making mistakes.
What I do mind is getting no reactions to my review comments. It feels
like I am getting ignored, so I might as well not have spent time on
reviewing in the first place. Secondly you cannot get your patch in
without addressing my review comments.
So let's be productive instead and move this forward.
> --- a/libavcodec/mpegvideo_enc.c
> +++ b/libavcodec/mpegvideo_enc.c
> @@ -90,9 +90,9 @@ void ff_convert_matrix(DSPContext *dsp, int (*qmat)[64],
> }
> } else if (dsp->fdct == fdct_ifast
> #ifndef FAAN_POSTSCALE
> - || dsp->fdct == ff_faandct
> + || dsp->fdct == ff_faandct
OK
> #endif
> - ) {
> + ) {
This was correct before.
> for (i = 0; i < 64; i++) {
> const int j = dsp->idct_permutation[i];
> /* 16 <= qscale * quant_matrix[i] <= 7905 */
> @@ -125,9 +125,9 @@ void ff_convert_matrix(DSPContext *dsp, int (*qmat)[64],
> int64_t max = 8191;
> if (dsp->fdct == fdct_ifast
> #ifndef FAAN_POSTSCALE
> - || dsp->fdct == ff_faandct
> + || dsp->fdct == ff_faandct
OK
> #endif
> - ) {
> + ) {
OK
Note how you place ) on the same column as ( here, while you
indent ) one more space in the hunk above.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
