On Tue, 27 Dec 2011 07:51:19 +0100, Luca Barbato <[email protected]> wrote:
> ---
> libavdevice/v4l2.c | 124
> ++++++++++++++++++++++++++++++++++++----------------
> 1 files changed, 86 insertions(+), 38 deletions(-)
>
> diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
> index 60e7dbf..f6d003b 100644
> --- a/libavdevice/v4l2.c
> +++ b/libavdevice/v4l2.c
> @@ -529,14 +560,16 @@ static int v4l2_set_parameters(AVFormatContext *s1,
> AVFormatParameters *ap)
> if (framerate_q.num != tpf->denominator ||
> framerate_q.den != tpf->numerator) {
> av_log(s1, AV_LOG_INFO,
> - "The driver changed the time per frame from %d/%d to
> %d/%d\n",
> + "The driver changed the time per frame from "
> + "%d/%d to %d/%d\n",
> framerate_q.den, framerate_q.num,
> tpf->numerator, tpf->denominator);
> }
> } else {
> - /* if timebase value is not set, read the timebase value from the
> driver */
> +/* if timebase value is not set, read the timebase value from the driver */
Why? Having the comment indented same as code makes more sense to me.
> @@ -695,7 +742,8 @@ static int v4l2_read_packet(AVFormatContext *s1, AVPacket
> *pkt)
>
> if (s1->streams[0]->codec->coded_frame && s->interlaced) {
> s1->streams[0]->codec->coded_frame->interlaced_frame = 1;
> - s1->streams[0]->codec->coded_frame->top_field_first =
> s->top_field_first;
> + s1->streams[0]->codec->coded_frame->top_field_first =
> + s->top_field_first;
I find this change too extreme. It's fine to try to fit in 80 lines
whenever it's reasonable, but strictly enforcing it everywhere makes the
code less readable. Surely your editor can do some automatic wrapping
for you, it won't look much worse than this.
--
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
