Derek Buitenhuis <[email protected]> writes: > On 28/12/2011 12:02 PM, Kostya Shishkov wrote: >>>> looks stupid >>> > >>> > Disgusting even. > > I do agree, but may I remind you we recently pushed this: > > http://git.libav.org/?p=libav.git;a=commitdiff;h=b4dc68803bd7fa73c2e37f55ae73b5fdb293c68d
Two wrongs do not make a right. > I'm all for a better solution, but I don't hear anyone offering any. > >>>> > > It obviously tries to say "if we can pad linesize to DWORD then do >>>> > it" and >>>> > > that's because M$ raw in AVI requires it. But it can be done in more >>>> > generic >>>> > > way and preferably with comment, like: >>>> > > >>>> > > // M$ raw data in AVI is padded to 4 bytes >>>> > > if (isRGB(avctx->pix_fmt)&& FFALIGN(linesize, 4) * height<= >>>> > buf_size) >>>> > > linesize = FFALIGN(linesize, 4); >>> > >>> > Why do "codecs" need to care about container quirks? Something doesn't >>> > smell quite right. >> Probably demuxer assumes that raw data is packed without any line padding >> while it's not true for M$ DIB (BMP, AVI). I wonder how to deal with it but >> no >> patch from me. > > This has come up numerous times with regards to AVI in Libav. I think > it's probably time it gets fixed properly. I agree, but this is not that proper fix. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
