On 29/12/2011 11:29 AM, Luca Barbato wrote:
---
  doc/indevs.texi    |    2 +-
  libavdevice/v4l2.c |   79 ++++++++++++++++++++++++++++++++++++++++++++++++----
  2 files changed, 74 insertions(+), 7 deletions(-)

[...]

+        if (vfd.flags & V4L2_FMT_FLAG_EMULATED) {
+            av_log(ctx, AV_LOG_WARNING, "%s", "Emulated");
+            continue;
+        }

Why not av_log(ctx, AV_LOG_WARNING, "Emulated"); ?

And perhaps a more descriptive warning?

The rest looks OK, but a second set of eyes could be nice.

- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to