On 29/12/11 19:09, Derek Buitenhuis wrote:
On 29/12/2011 11:29 AM, Luca Barbato wrote:
---
doc/indevs.texi | 2 +-
libavdevice/v4l2.c | 79
++++++++++++++++++++++++++++++++++++++++++++++++----
2 files changed, 74 insertions(+), 7 deletions(-)
[...]
+ if (vfd.flags & V4L2_FMT_FLAG_EMULATED) {
+ av_log(ctx, AV_LOG_WARNING, "%s", "Emulated");
+ continue;
+ }
Why not av_log(ctx, AV_LOG_WARNING, "Emulated"); ?
It might be faster and safer, the real reason is that initially it was
something like
av_log(.... (vfd.flags & V4L2_FMT_FLAG_EMULATED) ? "E" : " ")
And perhaps a more descriptive warning?
I could just make those entries disappear, we do not want to do
colorconversion or decoding in-kernel...
The rest looks OK, but a second set of eyes could be nice.
I'll wait for it. Tell me if I should amend it in a way or another.
lu
--
Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
