> On Thu, Dec 29, 2011 at 11:00:06PM +0100, Aneesh Dogra wrote:
>>
>> --- a/tests/fate.mak
>> +++ b/tests/fate.mak
>> @@ -246,5 +246,5 @@ FATE_TESTS += fate-westwood-aud
>>  fate-westwood-aud: CMD = md5  -i $(SAMPLES)/westwood-aud/excellent.aud
>> -f s16le
>>  FATE_TESTS += fate-wnv1
>>  fate-wnv1: CMD = framecrc  -i $(SAMPLES)/wnv1/wnv1-codec.avi -an
>> -FATE_TESTS += fate-xan-dpcm
>> -fate-xan-dpcm: CMD = md5  -i $(SAMPLES)/wc4-xan/wc4_2.avi -vn -f s16le
>> +FATE_TESTS += fate-dpcm_xan_audio
>> +fate-dpcm_xan_audio: CMD = md5  -i $(SAMPLES)/wc4-xan/wc4_2.avi -vn -f
>> s16le
>
> This renaming is nonsense, dpcm is clearly audio.
>
>> --- a/tests/fate2.mak
>> +++ b/tests/fate2.mak
>> @@ -87,3 +87,6 @@ fate-v410enc: CMD = md5 -f image2 -vcodec pgmyuv -i
>> $(TARGET_PATH)/tests/vsynth1
>>
>>  FATE_TESTS += fate-r210
>>  fate-r210: CMD = framecrc -i $(SAMPLES)/r210/r210.avi -pix_fmt rgb48le
>> +
>> +FATE_TESTS += fate-xxan_wc4_video
>> +fate-xxan_wc4_video: CMD = framecrc -i $(SAMPLES)/wc4-xan/wc4_2.avi -an
>> -vframes 10
>
> Same here, no _video suffix is necessary.

Moreover, while we're in the refactoring mood, these 2 tests should really
just be combined (fate-dpcm_xan_audio and fate-xxan_wc4_video). They both
operate on the same file. I suspect things got this way because we had the
audio decoder before the video decoder.

--
    -Mike Melanson

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to