Anton Khirnov <[email protected]> writes:

> Based on code by Michael Niedermayer.
> ---
>  avconv.c                  |   12 +-------
>  libavfilter/vsrc_buffer.c |   61 
> +++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 63 insertions(+), 10 deletions(-)

This seems wrong.  Resolution changes should be allowed if the immediate
consumer supports it.  If at some stage in the processing chain an
element does not support resolution changes, any auto-scaling should
happen there, not sooner, and certainly not bolted to the buffer source.

An obvious example of where this is wrong is when there is already a
scaler in the chain.  On a change in input resolution, the proper action
is then to reconfigure the existing scaler, not add another one.

Furthermore, it could be argued that automatic insertion of scalers is
evil in general if unless requested by the user.  At the very least, the
user should be offered some control over how it happens.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to