On Wed, Dec 21, 2011 at 11:11:44AM +0100, Diego Biurrun wrote:
> On Wed, Dec 21, 2011 at 09:50:58AM +0100, Diego Biurrun wrote:
> > On Wed, Dec 21, 2011 at 01:35:24AM +0000, Måns Rullgård wrote:
> > > Diego Biurrun <[email protected]> writes:
> > > > On Tue, Dec 20, 2011 at 04:32:10PM +0000, Mans Rullgard wrote:
> > > >> 
> > > >> --- a/configure
> > > >> +++ b/configure
> > > >> @@ -3116,6 +3116,7 @@ elif enabled gcc; then
> > > >>      check_cflags -Werror=missing-prototypes
> > > >> +    check_cflags -Werror=declaration-after-statement
> > > >>  elif enabled llvm_gcc; then
> > > >>      check_cflags -mllvm -stack-alignment=16
> > > >>  elif enabled clang; then
> > > >
> > > > This will not work, gcc will refuse to build all the AltiVec code.
> > > 
> > > It does now.
> > 
> > Except for one test in libavcodec:
> > 
> > CC      libavcodec/h264-test.o
> > libavcodec/h264.c: In function ‘fill_filter_caches_inter’:
> > libavcodec/h264.c:3257: warning: initialization from incompatible pointer 
> > type
> > libavcodec/h264.c:3272: warning: initialization from incompatible pointer 
> > type
> > libavcodec/h264.c:3305: warning: initialization from incompatible pointer 
> > type
> > libavcodec/h264.c: In function ‘decode_nal_units’:
> > libavcodec/h264.c:3792: warning: assignment discards qualifiers from 
> > pointer target type
> > libavcodec/h264.c: In function ‘main’:
> > libavcodec/h264.c:4134: error: ISO C90 forbids mixed declarations and code
> > libavcodec/h264.c:4159: error: ISO C90 forbids mixed declarations and code
> > make: *** [libavcodec/h264-test.o] Error 1
> 
> This is a problem with the START_TIMER/STOP_TIMER macros of which we
> have commented-out problematic instances in
> 
> libavcodec/dnxhdenc.c
> libavcodec/h264.c
> libavcodec/indeo5.c
> libpostproc/postprocess_template.c
> 
> Here are the error messages:
> 
> ~/src/priv/libav $ make -k all alltools examples testprogs
> CC      libavcodec/dnxhdenc.o
> libavcodec/dnxhdenc.c: In function ‘dnxhd_encode_thread’:
> libavcodec/dnxhdenc.c:586: error: ISO C90 forbids mixed declarations and code
> make: *** [libavcodec/dnxhdenc.o] Error 1
> CC      libavcodec/indeo5.o
> libavcodec/indeo5.c: In function ‘decode_frame’:
> libavcodec/indeo5.c:760: error: ISO C90 forbids mixed declarations and code
> make: *** [libavcodec/indeo5.o] Error 1
> CC      libpostproc/postprocess.o
> In file included from libpostproc/postprocess.c:601:
> libpostproc/postprocess_template.c: In function ‘do_a_deblock_MMX2’:
> libpostproc/postprocess_template.c:2475: error: ISO C90 forbids mixed 
> declarations and code
> make: *** [libpostproc/postprocess.o] Error 1
> make: Target `all' not remade because of errors.
> make: Target `alltools' not remade because of errors.
> make: Target `examples' not remade because of errors.
> CC      libavcodec/h264-test.o
> libavcodec/h264.c: In function ‘main’:
> libavcodec/h264.c:4134: error: ISO C90 forbids mixed declarations and code
> libavcodec/h264.c:4159: error: ISO C90 forbids mixed declarations and code
> make: *** [libavcodec/h264-test.o] Error 1
> make: Target `testprogs' not remade because of errors.

Suggestions?  I don't believe we should keep the test programs non-compiling.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to