On Wed, Feb 01, 2012 at 09:03:55PM -0800, Ronald S. Bultje wrote:
>
> --- a/configure
> +++ b/configure
> @@ -116,6 +116,9 @@ Configuration options:
> --enable-memalign-hack emulate memalign, interferes with memory debuggers
> + --enable-win64-xmm-clobber-test
> + check XMM registers for clobbering (Win64-only;
> + should be used only for debugging purposes)
> @@ -991,6 +994,7 @@ CONFIG_LIST="
> version3
> + win64_xmm_clobber_test
> x11grab
The name of this option is too long. Dropping the win64 from the name
would be a start, it does not appear to be that Win64-specific (anymore).
> --- a/libavcodec/x86/Makefile
> +++ b/libavcodec/x86/Makefile
> @@ -74,3 +74,4 @@ OBJS-$(HAVE_MMX) += x86/dsputil_mmx.o
> \
> x86/mpegvideo_mmx.o \
> x86/simple_idct_mmx.o \
>
> +OBJS-$(CONFIG_WIN64_XMM_CLOBBER_TEST) += x86/w64xmmtest.o
Try to put this in order please.
> --- /dev/null
> +++ b/libavcodec/x86/w64xmmtest.c
> @@ -0,0 +1,138 @@
> +
> +/**
> + * @file
> + */
Empty statement is empty.
> +wrap(avcodec_open2(AVCodecContext *avctx,
> + AVCodec *codec,
> + AVDictionary **options))
> +{
> + testxmmclobbers(open2, avctx, codec, options);
> +}
> +
> +wrap(avcodec_decode_audio4(AVCodecContext *avctx,
> + AVFrame *frame,
> + int *got_frame_ptr,
> + AVPacket *avpkt))
> +{
> + testxmmclobbers(decode_audio4, avctx, frame,
> + got_frame_ptr, avpkt);
> +}
> +
> +wrap(avcodec_decode_video2(AVCodecContext *avctx,
> + AVFrame *picture,
> + int *got_picture_ptr,
> + AVPacket *avpkt))
> +{
> + testxmmclobbers(decode_video2, avctx, picture,
> + got_picture_ptr, avpkt);
> +}
> +
> +wrap(avcodec_decode_subtitle2(AVCodecContext *avctx,
> + AVSubtitle *sub,
> + int *got_sub_ptr,
> + AVPacket *avpkt))
> +{
> + testxmmclobbers(decode_subtitle2, avctx, sub,
> + got_sub_ptr, avpkt);
> +}
> +
> +wrap(avcodec_encode_audio2(AVCodecContext *avctx,
> + AVPacket *avpkt,
> + const AVFrame *frame,
> + int *got_packet_ptr))
> +{
> + testxmmclobbers(encode_audio2, avctx, avpkt, frame,
> + got_packet_ptr);
> +}
> +
> +wrap(avcodec_encode_video(AVCodecContext *avctx,
> + uint8_t *buf, int buf_size,
> + const AVFrame *pict))
> +{
> + testxmmclobbers(encode_video, avctx, buf,
> + buf_size, pict);
> +}
> +
> +wrap(avcodec_encode_subtitle(AVCodecContext *avctx,
> + uint8_t *buf, int buf_size,
> + const AVSubtitle *sub))
> +{
> + testxmmclobbers(encode_subtitle, avctx, buf,
> + buf_size, sub);
> +}
You are breaking many lines that do not need breaking.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
