On Thu, Feb 02, 2012 at 07:14:06AM -0800, Ronald S. Bultje wrote:
> On Thu, Feb 2, 2012 at 4:12 AM, Diego Biurrun <[email protected]> wrote:
> > On Wed, Feb 01, 2012 at 09:03:55PM -0800, Ronald S. Bultje wrote:
> >>
> >> --- a/configure
> >> +++ b/configure
> >> @@ -116,6 +116,9 @@ Configuration options:
> >>    --enable-memalign-hack   emulate memalign, interferes with memory 
> >> debuggers
> >> +  --enable-win64-xmm-clobber-test
> >> +                           check XMM registers for clobbering (Win64-only;
> >> +                           should be used only for debugging purposes)
> >> @@ -991,6 +994,7 @@ CONFIG_LIST="
> >>      version3
> >> +    win64_xmm_clobber_test
> >>      x11grab
> >
> > The name of this option is too long.  Dropping the win64 from the name
> > would be a start, it does not appear to be that Win64-specific (anymore).
> 
> The code probably compiles on other 64-bit platforms, but I assure you
> it does nothing useful except aborting (and yes, it will directly
> abort on any other platform, because they are expected to clobber the
> XMM registers, unlike Win64).

Then just mention in the description that it is for Win64, but keep the
option name shorter please.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to