On Fri, Feb 03, 2012 at 08:24:37AM +0100, Anton Khirnov wrote: > > On Tue, 31 Jan 2012 18:02:23 +0100, Diego Biurrun <[email protected]> wrote: > > On Sun, Jan 29, 2012 at 10:50:52AM +0100, Anton Khirnov wrote: > > > > > > --- a/libavcodec/options.c > > > +++ b/libavcodec/options.c > > > @@ -75,9 +75,151 @@ static const AVClass *codec_child_class_next(const > > > AVClass *prev) > > > > > > static const AVOption options[]={ > > > -{"b", "set bitrate (in bits/s)", OFFSET(bit_rate), AV_OPT_TYPE_INT, > > > {.dbl = AV_CODEC_DEFAULT_BITRATE }, INT_MIN, INT_MAX, V|A|E}, > > > -{"bt", "set video bitrate tolerance (in bits/s)", > > > OFFSET(bit_rate_tolerance), AV_OPT_TYPE_INT, {.dbl = > > > AV_CODEC_DEFAULT_BITRATE*20 }, 1, INT_MAX, V|E}, > > > -{"sub_id", NULL, OFFSET(sub_id), AV_OPT_TYPE_INT, {.dbl = DEFAULT }, > > > INT_MIN, INT_MAX}, > > > +{"b", "set bitrate (in bits/s)", > > > OFFSET(bit_rate), AV_OPT_TYPE_INT, > > > {AV_CODEC_DEFAULT_BITRATE}, INT_MIN, INT_MAX, V|A|E}, > > > +{"bt", "set video bitrate tolerance (in bits/s)", > > > OFFSET(bit_rate_tolerance), AV_OPT_TYPE_INT, > > > {AV_CODEC_DEFAULT_BITRATE*20}, 1, INT_MAX, V|E}, > > > > Please split the lines, 200 characters is a little too much. > > What for? So it remains exactly as unreadable as it is now?
Right now it will get broken in random places instead of designated ones. This does not improve readability in any way. These lines do not fit my maximized terminals, they are crazy long. > > Also add spaces around |. > > To make the lines even longer? With the vertical alignment it looks > quite readable to me even without spaces. We use spaces around operators everywhere else, this is not a good place to start making exceptions. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
