On Sun, Feb 12, 2012 at 12:23:45PM +0100, Anton Khirnov wrote: > On Sun, 12 Feb 2012 10:54:31 +0100, Diego Biurrun <[email protected]> wrote: > > On Fri, Feb 03, 2012 at 08:24:37AM +0100, Anton Khirnov wrote: > > > On Tue, 31 Jan 2012 18:02:23 +0100, Diego Biurrun <[email protected]> > > > wrote: > > > > On Sun, Jan 29, 2012 at 10:50:52AM +0100, Anton Khirnov wrote: > > > > > > > > > > --- a/libavcodec/options.c > > > > > +++ b/libavcodec/options.c > > > > > @@ -75,9 +75,151 @@ static const AVClass > > > > > *codec_child_class_next(const AVClass *prev) > > > > > > > > > > static const AVOption options[]={ > > > > > -{"b", "set bitrate (in bits/s)", OFFSET(bit_rate), AV_OPT_TYPE_INT, > > > > > {.dbl = AV_CODEC_DEFAULT_BITRATE }, INT_MIN, INT_MAX, V|A|E}, > > > > > -{"bt", "set video bitrate tolerance (in bits/s)", > > > > > OFFSET(bit_rate_tolerance), AV_OPT_TYPE_INT, {.dbl = > > > > > AV_CODEC_DEFAULT_BITRATE*20 }, 1, INT_MAX, V|E}, > > > > > -{"sub_id", NULL, OFFSET(sub_id), AV_OPT_TYPE_INT, {.dbl = DEFAULT }, > > > > > INT_MIN, INT_MAX}, > > > > > +{"b", "set bitrate (in bits/s)", > > > > > OFFSET(bit_rate), AV_OPT_TYPE_INT, > > > > > {AV_CODEC_DEFAULT_BITRATE}, INT_MIN, INT_MAX, V|A|E}, > > > > > +{"bt", "set video bitrate tolerance (in bits/s)", > > > > > OFFSET(bit_rate_tolerance), AV_OPT_TYPE_INT, > > > > > {AV_CODEC_DEFAULT_BITRATE*20}, 1, INT_MAX, V|E}, > > > > > > > > Please split the lines, 200 characters is a little too much. > > > > > > What for? So it remains exactly as unreadable as it is now? > > > > Right now it will get broken in random places instead of designated > > ones. This does not improve readability in any way. These lines do > > not fit my maximized terminals, they are crazy long. > > > > The only way to make this table remotely close to something readable is > vertical alignment. Breaking those lines, whether automatically or > manually, makes this table unreadable, so I might as well not bother. > > So this patch > 1) doesn't make readability worse on small terminals > 2) significantly improves it on large terminals > > I think that's an overall improvement.
I disagree on both points. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
