On 18/03/2012 1:35 PM, Diego Biurrun wrote: >> + * ZeroCodec Decoder >> + * >> + * Copyright (c) 2012, Derek Buitenhuis >> + * >> + * This file is part of Libav. > > This sentence forms part of the GPL license boilerplate, but it has no > place in the ISC license.
I just included this, since by default ISC doesn't even include the project name. I'll remove it if it causes trouble. >> +#include <zlib.h> >> +#include "avcodec.h" > > Please separate system and local headers by an empty line. OK. > >> + zstream->next_in = avpkt->data; >> + zstream->avail_in = avpkt->size; > > nit: stray double space What? > nit: We don't usually leave empty lines after if/for-blocks. This would be my personal coding style. (I think it looks less ugly than not.) If it bothers people, I'll change it. > The av_log lines are long and can easily be shortened. At the expense of a bit of verbosity, yes. I did accidentally go over 80 cols here, and will add a line break. >> + *data_size = sizeof(AVFrame); >> + *(AVFrame *)data = *pic; > > nit: align OK. - Derek _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
