On Sun, Mar 18, 2012 at 01:43:51PM -0400, Derek Buitenhuis wrote: > On 18/03/2012 1:35 PM, Diego Biurrun wrote: > >> + * ZeroCodec Decoder > >> + * > >> + * Copyright (c) 2012, Derek Buitenhuis > >> + * > >> + * This file is part of Libav. > > > > This sentence forms part of the GPL license boilerplate, but it has no > > place in the ISC license. > > I just included this, since by default ISC doesn't even include > the project name. I'll remove it if it causes trouble.
Remove it. This is the full license, not just a boilerplate pointer to the license. > >> + zstream->next_in = avpkt->data; > >> + zstream->avail_in = avpkt->size; > > > > nit: stray double space > > What? stray double space before '=' - not important.. > > nit: We don't usually leave empty lines after if/for-blocks. > > This would be my personal coding style. (I think it looks > less ugly than not.) If it bothers people, I'll change it. I prefer no empty lines and you don't have empty lines in most other places. But I have no strong opinion, do whatever you prefer. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
