On Mon, Mar 26, 2012 at 12:03:12PM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > --- a/configure > > +++ b/configure > > @@ -115,7 +115,8 @@ Component options: > > --disable-dct disable DCT code > > - --disable-fft disable FFT code > > + --disable-faandct disable floating point AAN DCT code > > + --disable-jpegdct disable JPEG DCT code > > --disable-mdct disable MDCT code > > --disable-rdft disable RDFT code > > --disable-fft disable FFT code > > Please don't mix these options with the FFT ones. They have nothing to > do with one another.
Removing the "--disable-fft" option is a stray change. Grouping all the DCT options together seems logical, so I believe the order is good. I'll split the stray change off into a separate commit. Apparently I slipped up while rebasing the patch that restructured the help output. Sorry about that. > > @@ -935,6 +936,7 @@ CONFIG_LIST=" > > doc > > dwt > > dxva2 > > + faandct > > fastdiv > > fft > > frei0r > > @@ -942,6 +944,7 @@ CONFIG_LIST=" > > gpl > > gray > > hardcoded_tables > > + jpegdct > > libcdio > > libdc1394 > > libdirac > > @@ -1289,7 +1292,7 @@ cavs_decoder_select="golomb" > > cook_decoder_select="mdct sinewin" > > cscd_decoder_suggest="zlib" > > dca_decoder_select="mdct" > > -dnxhd_encoder_select="aandct" > > +dnxhd_encoder_select="aandct faandct jpegdct" > > dxa_decoder_select="zlib" > > eac3_decoder_select="ac3_decoder" > > eac3_encoder_select="mdct ac3dsp" > > Nothing strictly requires faandct, so this _select and others like it > are wrong. Most of the jpegdct dependencies also look dubious. I'll send an updated patch after I run it through my script that tests individual compilation of all components. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
