Diego Biurrun <[email protected]> writes:

> On Mon, Mar 26, 2012 at 01:00:20PM +0100, Måns Rullgård wrote:
>> Diego Biurrun <[email protected]> writes:
>> 
>> > On Mon, Mar 26, 2012 at 12:03:12PM +0100, Måns Rullgård wrote:
>> >> Diego Biurrun <[email protected]> writes:
>> >> > --- a/configure
>> >> > +++ b/configure
>> >> > @@ -115,7 +115,8 @@ Component options:
>> >> >    --disable-dct            disable DCT code
>> >> > -  --disable-fft            disable FFT code
>> >> > +  --disable-faandct        disable floating point AAN DCT code
>> >> > +  --disable-jpegdct        disable JPEG DCT code
>> >> >    --disable-mdct           disable MDCT code
>> >> >    --disable-rdft           disable RDFT code
>> >> >    --disable-fft            disable FFT code
>> >> 
>> >> Please don't mix these options with the FFT ones.  They have nothing to
>> >> do with one another.
>> >
>> > Removing the "--disable-fft" option is a stray change.  Grouping all
>> > the DCT options together seems logical, so I believe the order is good.
>> 
>> It is not.  --disable-dct refers to the 1D DCT based on the FFT.  The
>> rest of the dct options are for 8x8 2D DCTs used in video codecs.  Other
>> than being based on the same mathematical principles, they have nothing
>> in common.
>
> Where would you like to see --disable-faandct and --disable-jpegdct placed?

Anywhere but confusingly intermingled with the fft options.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to