Diego Biurrun <[email protected]> writes: > All CFLAGS settings are handled from configure; it is the proper place. > --- > > This patch could be extended to with add_host_cflags and similar > infrastructure for configure, but it's not immediately obvious that > such far-reaching changes would be worth the trouble when host_cflags > is not modified in many places. In any case this minimal patch I > consider an improvement over the status quo. > > configure | 5 +++++ > libavcodec/Makefile | 6 ------ > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/configure b/configure > index 9e66ad4..ab0e025 100755 > --- a/configure > +++ b/configure > @@ -2399,6 +2399,11 @@ check_cc -D_LARGEFILE_SOURCE <<EOF && add_cppflags > -D_LARGEFILE_SOURCE > #include <stdlib.h> > EOF > > +if enabled small; then > + host_cflags="$host_cflags -DCONFIG_SMALL=1" > +else > + host_cflags="$host_cflags -DCONFIG_SMALL=0" > +fi > check_host_cflags -std=c99 > check_host_cflags -Wall > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 2929296..77526f1 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -720,12 +720,6 @@ TRIG_TABLES := $(TRIG_TABLES:%=$(SUBDIR)%_tables.c) > $(TRIG_TABLES): $(SUBDIR)%_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF) > $(M)./$< $* > $@ > > -ifdef CONFIG_SMALL > -$(SUBDIR)%_tablegen$(HOSTEXESUF): HOSTCFLAGS += -DCONFIG_SMALL=1 > -else > -$(SUBDIR)%_tablegen$(HOSTEXESUF): HOSTCFLAGS += -DCONFIG_SMALL=0 > -endif > - > GEN_HEADERS = cbrt_tables.h aacps_tables.h aac_tables.h dv_tables.h \ > sinewin_tables.h mpegaudio_tables.h motionpixels_tables.h \ > pcm_tables.h qdm2_tables.h > --
The -DCONFIG_SMALL flag is specific to the tablegen files. Your change adds it everywhere, which serves no purpose. Patch rejected. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
