On Wed, Mar 28, 2012 at 05:40:55PM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > > All CFLAGS settings are handled from configure; it is the proper place. > > --- a/configure > > +++ b/configure > > @@ -2399,6 +2399,11 @@ check_cc -D_LARGEFILE_SOURCE <<EOF && add_cppflags > > -D_LARGEFILE_SOURCE > > > > +if enabled small; then > > + host_cflags="$host_cflags -DCONFIG_SMALL=1" > > +else > > + host_cflags="$host_cflags -DCONFIG_SMALL=0" > > +fi > > check_host_cflags -std=c99 > > check_host_cflags -Wall > > > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -720,12 +720,6 @@ TRIG_TABLES := $(TRIG_TABLES:%=$(SUBDIR)%_tables.c) > > > > -ifdef CONFIG_SMALL > > -$(SUBDIR)%_tablegen$(HOSTEXESUF): HOSTCFLAGS += -DCONFIG_SMALL=1 > > -else > > -$(SUBDIR)%_tablegen$(HOSTEXESUF): HOSTCFLAGS += -DCONFIG_SMALL=0 > > -endif > > The -DCONFIG_SMALL flag is specific to the tablegen files. Your change > adds it everywhere, which serves no purpose.
I know. It sounds like a small price to pay for eliminating this hack from the Makefiles. It's not like -DCONFIG_SMALL hurts on the command line ... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
