On Mon, Apr 16, 2012 at 09:36:47AM +0200, Anton Khirnov wrote:
>
> On Wed, 04 Apr 2012 20:14:20 +0200, Diego Biurrun <di...@biurrun.de> wrote:
> > --- a/libavcodec/dv.c
> > +++ b/libavcodec/dv.c
> > @@ -467,6 +476,28 @@ static av_always_inline int
> > dv_guess_dct_mode(DVVideoContext *s, uint8_t *data,
> >
> > +static const int dv_weight_bits = 18;
>
> Unrelated -- I wonder why is this not a macro.
>
> > --- a/libavcodec/dvdec.c
> > +++ b/libavcodec/dvdec.c
> > @@ -54,6 +54,8 @@ typedef struct BlockInfo {
> >
> > +static const int dv_iweight_bits = 14;
>
> Same here.
So the compiler can typecheck. Compare
#define CONSTANT -1
[... lines and lines of code ...]
const uint32_t variable = CONSTANT;
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
