On Fri, Jun 22, 2012 at 07:07:44PM +0200, Anton Khirnov wrote:
> 
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -165,6 +165,47 @@ static int mov_read_mac_string(MOVContext *c, 
> AVIOContext *pb, int len,
>  
> +static int mov_read_covr(MOVContext *c, AVIOContext *pb, int type, int len)

I remember somebody saying that he would add an 'e' to O_CREAT, so
please add an 'e' to "cover" :)

> +    st->disposition              |= AV_DISPOSITION_ATTACHED_PIC;
> +
> +    st->attached_pic              = pkt;
> +    st->attached_pic.stream_index = st->index;
> +    st->attached_pic.flags       |= AV_PKT_FLAG_KEY;
> +
> +    st->codec->codec_type = AVMEDIA_TYPE_VIDEO;
> +    st->codec->codec_id   = id;

nit: Why not align all lines?

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to