On Fri, Jun 22, 2012 at 07:33:01PM +0200, Anton Khirnov wrote: > > On Fri, 22 Jun 2012 19:26:02 +0200, Diego Biurrun <[email protected]> wrote: > > On Fri, Jun 22, 2012 at 07:07:44PM +0200, Anton Khirnov wrote: > > > > > > --- a/libavformat/mov.c > > > +++ b/libavformat/mov.c > > > @@ -165,6 +165,47 @@ static int mov_read_mac_string(MOVContext *c, > > > AVIOContext *pb, int len, > > > > > > +static int mov_read_covr(MOVContext *c, AVIOContext *pb, int type, int > > > len) > > > > I remember somebody saying that he would add an 'e' to O_CREAT, so > > please add an 'e' to "cover" :) > > > > The convention in this file seems to be mov_read_<box name>. The box > name in this case is 'covr'. I'd prefer to keep it consistent.
In that case I agree - keep the name. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
