Christophe Gisquet <[email protected]> writes: > 2012/6/27 Jason Garrett-Glaser <[email protected]>: >> This should be REP_RET, but otherwise looks good. Will probably be faster, >> too. > > Yes, as mentioned by Mans, the memcpy provided by whatever mingw-w64 > uses (old msvcrt?) is not very fast: see cycle count in commit > message. > > But even with a better memcpy, it should be a win. > > New patch attached, addressing also Mans' comment. > > -- > Christophe > > From 916bd251088726071a25f38e2ea243dc124f426e Mon Sep 17 00:00:00 2001 > From: Christophe Gisquet <[email protected]> > Date: Tue, 26 Jun 2012 16:10:33 +0200 > Subject: [PATCH] FFT x86: replace call to memcpy by a loop > > The function call was a mess to handle, and memcpy cannot make the assumptions > we do in the new code. > > Tested on an IMC sample: 430c -> 370c. > --- > libavcodec/x86/fft_mmx.asm | 36 +++++++++++++----------------------- > 1 files changed, 13 insertions(+), 23 deletions(-)
Thanks. Pushed with the extern declaration of memcpy removed as well. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
