On Thu, Jul 05, 2012 at 12:43:18PM +0200, Diego Biurrun wrote:
> On Fri, Jul 29, 2011 at 01:02:41PM +0200, Diego Biurrun wrote:
> >
> > --- a/libavcodec/qdm2.c
> > +++ b/libavcodec/qdm2.c
> > @@ -1654,52 +1654,6 @@ static av_cold void qdm2_init(QDM2Context *q) {
> >
> > -#if 0
> > -static void dump_context(QDM2Context *q)
> > -{
> > - int i;
> > -#define PRINT(a,b) av_log(NULL,AV_LOG_DEBUG," %s = %d\n", a, b);
> > - PRINT("compressed_data",q->compressed_data);
> > - PRINT("compressed_size",q->compressed_size);
> > - PRINT("frame_size",q->frame_size);
> > - PRINT("checksum_size",q->checksum_size);
> > - PRINT("channels",q->channels);
> > - PRINT("nb_channels",q->nb_channels);
> > - PRINT("fft_frame_size",q->fft_frame_size);
> > - PRINT("fft_size",q->fft_size);
> > - PRINT("sub_sampling",q->sub_sampling);
> > - PRINT("fft_order",q->fft_order);
> > - PRINT("group_order",q->group_order);
> > - PRINT("group_size",q->group_size);
> > - PRINT("sub_packet",q->sub_packet);
> > - PRINT("frequency_range",q->frequency_range);
> > - PRINT("has_errors",q->has_errors);
> > - PRINT("fft_tone_end",q->fft_tone_end);
> > - PRINT("fft_tone_start",q->fft_tone_start);
> > - PRINT("fft_coefs_index",q->fft_coefs_index);
> > - PRINT("coeff_per_sb_select",q->coeff_per_sb_select);
> > - PRINT("cm_table_select",q->cm_table_select);
> > - PRINT("noise_idx",q->noise_idx);
> > -
> > - for (i = q->fft_tone_start; i < q->fft_tone_end; i++) {
> > - FFTTone *t = &q->fft_tones[i];
> > - av_log(NULL,AV_LOG_DEBUG,"Tone (%d) dump:\n", i);
> > - av_log(NULL,AV_LOG_DEBUG," level = %f\n", t->level);
> > -// PRINT(" level", t->level);
> > - PRINT(" phase", t->phase);
> > - PRINT(" phase_shift", t->phase_shift);
> > - PRINT(" duration", t->duration);
> > - PRINT(" samples_im", t->samples_im);
> > - PRINT(" samples_re", t->samples_re);
> > - PRINT(" table", t->table);
> > - }
> > -}
> > -#endif
>
> ping
>
> This fails to compile if enabled since 3.5 years and prints nonsense
> for even longer since some of those conversion specifiers are wrong.
>
> IOW nobody has used it in ages. As the function does not exactly require
> wizardly skill to restore in a similar form if the need should arise
> in the future I suggest just dropping the cruft.
fine with me
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
