Diego Biurrun <[email protected]> writes: > --- > libavcodec/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 8851b89..f43bcf4 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -588,7 +588,7 @@ OBJS-$(CONFIG_CAF_DEMUXER) += mpeg4audio.o > mpegaudiodata.o \ > OBJS-$(CONFIG_DV_DEMUXER) += dv_profile.o > OBJS-$(CONFIG_DV_MUXER) += dv_profile.o > OBJS-$(CONFIG_FLAC_DEMUXER) += flacdec.o flacdata.o flac.o \ > - flacdsp.o > + flacdsp.o vorbis_parser.o xiph.o > OBJS-$(CONFIG_FLAC_MUXER) += flacdec.o flacdata.o flac.o \ > flacdsp.o > OBJS-$(CONFIG_FLV_DEMUXER) += mpeg4audio.o > --
While correct in some sense, this is not OK. The problem is that the demuxer uses a header parsing function from flacdec.c, and other functions in flacdec.c need flacdsp. The proper solution is to move the shared functions to another file. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
