On Tue, Jul 10, 2012 at 07:26:34PM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > > > --- a/libavcodec/Makefile > > +++ b/libavcodec/Makefile > > @@ -588,7 +588,7 @@ OBJS-$(CONFIG_CAF_DEMUXER) += mpeg4audio.o > > mpegaudiodata.o \ > > OBJS-$(CONFIG_DV_MUXER) += dv_profile.o > > OBJS-$(CONFIG_FLAC_DEMUXER) += flacdec.o flacdata.o flac.o \ > > - flacdsp.o > > + flacdsp.o vorbis_parser.o xiph.o > > OBJS-$(CONFIG_FLAC_MUXER) += flacdec.o flacdata.o flac.o \ > > flacdsp.o > > While correct in some sense, this is not OK. The problem is that the > demuxer uses a header parsing function from flacdec.c, and other > functions in flacdec.c need flacdsp. The proper solution is to move the > shared functions to another file.
Your comment does not match the patch - this is not about flacdec vs. flacdsp. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
