On Thu, Jul 12, 2012 at 07:10:45PM +0200, Diego Biurrun wrote:
> On Thu, Jul 12, 2012 at 06:50:29PM +0200, Kostya Shishkov wrote:
> > On Thu, Jul 12, 2012 at 06:11:50PM +0200, Diego Biurrun wrote:
> > > On Wed, Jul 11, 2012 at 08:00:43AM +0200, Kostya Shishkov wrote:
> > > > --- /dev/null
> > > > +++ b/libavcodec/mss4.c
> > > > @@ -0,0 +1,680 @@
> > > > +static inline int get_coeff(GetBitContext *gb, VLC *vlc)
> > > > +{
> > > > + int val = get_vlc2(gb, vlc->table, vlc->bits, 2);
> > > > +
> > > > + return get_coeff_bits(gb, val);
> > >
> > > pointless variable indirection?
> >
> > return get_coeff_bits(gb, get_vlc2(gb, vlc->table, vlc->bits, 2));
> >
> > would look too LISPy to me and less clear
>
> Are you saying I was spoiled through functional programming? :)
No, but you should keep better isolation between two approaches ;)
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
