On Wed, 25 Jul 2012 02:45:35 +0000, Loren Merritt <[email protected]> 
wrote:
> 14% faster on penryn, 2% on sandybridge, 9% on bulldozer
> ---
>  libavfilter/vf_hqdn3d.c |  166 +++++++++++++++-------------------------------
>  1 files changed, 54 insertions(+), 112 deletions(-)
> 
> diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c
> index 8e2a6a2..fdb2ecb 100644
> --- a/libavfilter/vf_hqdn3d.c
> +++ b/libavfilter/vf_hqdn3d.c
> @@ -1,6 +1,7 @@
>  /*
>   * Copyright (c) 2003 Daniel Moreno <comac AT comac DOT darktech DOT org>
>   * Copyright (c) 2010 Baptiste Coudurier
> + * Copyright (c) 2012 Loren Merritt
>   *
>   * This file is part of Libav, ported from MPlayer.
>   *
> @@ -40,9 +41,8 @@ typedef struct {
>  
>  static inline uint32_t lowpass(unsigned int prev, unsigned int cur, int 
> *coef)
>  {
> -    //    int dmul= (prev&0xFFFFFF)-(cur&0xFFFFFF);
>      int dmul = prev-cur;
> -    uint32_t d = ((dmul+0x10007FF)>>12);
> +    unsigned int d = (dmul+0x10007FF)>>12; // 0x1000 to convert to unsigned, 
> 7FF for rounding

In the previous patch you changed it from unsigned to uint32_t, now
you're changing it back. Is there a reason for that?

-- 
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to