On Tue, Jul 31, 2012 at 04:33:37PM -0700, Ronald S. Bultje wrote: > On Tue, Jul 31, 2012 at 3:17 PM, Diego Biurrun <[email protected]> wrote: > > --- > > libavcodec/x86/vp8dsp.asm | 143 > > +++++++++++++++++++++------------------------ > > 1 files changed, 66 insertions(+), 77 deletions(-) > > This is silly, the two codepaths share not a single instruction. > > Also, this isn't a port to cpuflags, all of vp8dsp already uses > cpuflags. It ports a macro to use cpuflags:
This is exactly what the log message claims it to be: x86: vp8dsp: port FILTER_BILINEAR macro to cpuflags > %macro version_ssse3 > .. > %endmacro > > %macro version_mmx2 > .. > %endmacro > > becomes > > %macro version > %if cpuflag(ssse3) > .. > %else > .. > %endif > %endmacro > > Again, I don't know if this is in any way helpful or not, I honestly doubt it. I'll send in a fresh version that does a bit more refactoring. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
