On 07/31/2012 06:17 PM, Diego Biurrun wrote: > --- > libavcodec/x86/h264_intrapred.asm | 27 --------------------------- > libavcodec/x86/h264_intrapred_10bit.asm | 16 ---------------- > libavcodec/x86/h264_qpel_10bit.asm | 4 ---- > libavutil/x86/x86util.asm | 16 ++++++++-------- > libswscale/x86/output.asm | 4 +--- > 5 files changed, 9 insertions(+), 58 deletions(-) > [...] > diff --git a/libavutil/x86/x86util.asm b/libavutil/x86/x86util.asm > index 27eca3a..18c804c 100644 > --- a/libavutil/x86/x86util.asm > +++ b/libavutil/x86/x86util.asm > @@ -280,7 +280,14 @@ > %endif > %endmacro > > -%macro PALIGNR_MMX 4-5 ; [dst,] src1, src2, imm, tmp > +%macro PALIGNR 4-5 > +%if cpuflag(ssse3) > +%if %0==5 > + palignr %1, %2, %3, %4 > +%else > + palignr %1, %2, %3 > +%endif > +%elif cpuflag(mmx) ; [dst,] src1, src2, imm, tmp > %define %%dst %1 > %if %0==5 > %ifnidn %1, %2 > @@ -299,13 +306,6 @@ > psrldq %4, %3 > %endif > por %%dst, %4 > -%endmacro > - > -%macro PALIGNR_SSSE3 4-5 > -%if %0==5 > - palignr %1, %2, %3, %4 > -%else > - palignr %1, %2, %3 > %endif > %endmacro
Please put the comment with macro arguments on the same line as the macro definition. Also, cpuflag(mmx) is not necessary. This macro cannot be called from a non-SIMD function because it operates on mm registers. Thanks, Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
