On 2012-08-07 20:51:46 -0700, Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Aug 7, 2012 at 7:09 PM, Nathan Caldwell <[email protected]> wrote:
> > From: Hendrik Leppkes <[email protected]>
> >
> > Signed-off-by: Michael Niedermayer <[email protected]>
> > ---
> >  libavcodec/lagarith.c |   15 ++++++++-------
> >  1 files changed, 8 insertions(+), 7 deletions(-)
> 
> I have the distinct feeling that some sort of ff_thread_finish_setup()
> is missing - does this give any speedup at all?

ff_thread_get_buffer() calls ff_thread_finish_setup() if
thread_safe_callbacks are not set and the codec has no
update_thread_context function pointer set.

If thread_safe_callbacks is set without update_thread_context
ff_thread_finish_setup() is called from the worker before decode().

So it's fine although I'm not sure if I like this implicit calling.

Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to